Enable the example projects to use locally linked versions of the Vime packages #227
Conversation
The local icons are used at development time, but were incorrectly copied without preserving the directory structure by cpy-cli. This commit moves that responsibility to a Stencil copy task.
Previously this would result in duplicate copies of React.
This means that they can be used with locally linked versions of the @vime packages if desired. By default, the build command will only run on the public packages.
|
@rossng is attempting to deploy a commit to the Vidstack Team on Vercel. A member of the Team first needs to authorize it. |
|
Looks awesome to me. Not sure if this is related but getting some TS errors in CI? Seems unrelated to your changes though. Maybe we can patch in another PR. I also invited you to join the Vime organization so you can have more access. Let me know what you need. Thank you for the PR!
|
|
Feel free to merge once you've accepted invite. Just ping me for reviews on larger changes 😄 |
|
Just added another change to switch the Angular packages to the |
|
Having a look at the build error now. |
Stencil brings its own TypeScript with it, perhaps the version clash is breaking something?
|
After some fiddling CI seems to be working again 🙂. I don't have write permissions on the repo, but probably best if you look over the last few commits anyway @mihar-22! Probably no need to do a release after this merge, there will be some actual end-user facing stuff coming up soon. |
|
Awesome. You have write access now. The changes look good to me. It'd be nice if we didn't have to duplicate |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vidstack/vime/3KsjDDPoeM5p6PgDgc9d1ETSaL3h |
|
I thought the same, but seems to be unsolved by Prettier so far: prettier/prettier#8506 |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, it is not possible to use
npm linkor Lerna to use the local version of the@vime/*packages. There were a number of issues preventing this, all of which should be fixed by this PR.The main motivation for this change is to make it possible to quickly test local changes to
@vime/corewithout any ceremony.Issue Number: N/A
What is the new behavior?
examples/*has been added to the Lerna workspaces, making it possible to bootstrap the@vime/*packages in these projects.npm run buildhas been changed to run only on the public packages (i.e. noprivate: true). This preserves the existing behaviour that examples will not be built during CI.npm run bootstrap:allcommand is introduced to allow bootstrapping the examples if desired.@vime/core: copy theicons/folder structure correctly, so icons load whenNODE_ENV === development.@vime/react-example: resolvereactandreact-domcorrectly when using linked packages@vime/rollup-example: update the CSS extension to make CSS generation work@vime/stencil-example: fix icons not being found in dev mode@vime/webpack-example: ensure Webpack always loads the extracted CSS@vime/angular-example: preserve symlinks in Angular configDoes this introduce a breaking change?
Other information