-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the example projects to use locally linked versions of the Vime packages #227
Merged
Commits on Jul 13, 2021
-
fix: preserve dir structure when bundling core icons
The local icons are used at development time, but were incorrectly copied without preserving the directory structure by cpy-cli. This commit moves that responsibility to a Stencil copy task.
Configuration menu - View commit details
-
Copy full SHA for b7d52e9 - Browse repository at this point
Copy the full SHA b7d52e9View commit details -
fix: ensure React example works with locally-linked package
Previously this would result in duplicate copies of React.
Configuration menu - View commit details
-
Copy full SHA for 22bcfdd - Browse repository at this point
Copy the full SHA 22bcfddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 787297a - Browse repository at this point
Copy the full SHA 787297aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8478199 - Browse repository at this point
Copy the full SHA 8478199View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25288ab - Browse repository at this point
Copy the full SHA 25288abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 376c908 - Browse repository at this point
Copy the full SHA 376c908View commit details -
build: add the examples as Lerna packages
This means that they can be used with locally linked versions of the @vime packages if desired. By default, the build command will only run on the public packages.
Configuration menu - View commit details
-
Copy full SHA for 2cb0a17 - Browse repository at this point
Copy the full SHA 2cb0a17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21aad82 - Browse repository at this point
Copy the full SHA 21aad82View commit details -
build: remove typescript devdependency from @vime/core
Stencil brings its own TypeScript with it, perhaps the version clash is breaking something?
Configuration menu - View commit details
-
Copy full SHA for 76e17fa - Browse repository at this point
Copy the full SHA 76e17faView commit details -
Configuration menu - View commit details
-
Copy full SHA for f767c25 - Browse repository at this point
Copy the full SHA f767c25View commit details -
Configuration menu - View commit details
-
Copy full SHA for bce3905 - Browse repository at this point
Copy the full SHA bce3905View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2de27c7 - Browse repository at this point
Copy the full SHA 2de27c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e78efa7 - Browse repository at this point
Copy the full SHA e78efa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9908fd0 - Browse repository at this point
Copy the full SHA 9908fd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63ef363 - Browse repository at this point
Copy the full SHA 63ef363View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.