Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 6.0 support #59

Open
azimidev opened this issue Sep 3, 2019 · 18 comments
Open

Laravel 6.0 support #59

azimidev opened this issue Sep 3, 2019 · 18 comments

Comments

@azimidev
Copy link

azimidev commented Sep 3, 2019

Any chance you can make this package compatible for Laravel 6 and publish in packagist as soon as you can

@jnbn
Copy link
Contributor

jnbn commented Sep 4, 2019

Just opened a PR on #60

@BryanMootoosamy
Copy link

Actually, just bumping the version is not enough. Vimeo/laravel use the package vimeo/vimeo-api that use ankitpokhrel/tus-php locked to version 0.1.0. The problem is, ankitpokhrel/tus-php 0.1.0 require Carbon 1 and not Carbon 2 that is the main requirement of laravel 6

@asterism612
Copy link

not supported yet.
when support laravel6?

@jnbn
Copy link
Contributor

jnbn commented Sep 18, 2019

@asterism612 after the last PR it should work. Can you please define what's wrong about it?

@azimidev
Copy link
Author

I still get this

vimeo/laravel 5.4.0 requires illuminate/contracts ^5.8 -> satisfiable by illuminate/contracts[v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.33, v5.8.34, v5.8.35, v5.8.4, v5.8.8, v5.8.9].

@jnbn
Copy link
Contributor

jnbn commented Sep 18, 2019

I've changed it on

"illuminate/contracts": "^5.8|^6.0",
so there should't be a problem.

@azimidev
Copy link
Author

azimidev commented Sep 18, 2019

I can see that, also it's been merged, hasn't it? However, has it been tagged? Because I am using

 "vimeo/laravel": "^5.4"

in composer.json file. is that correct? if so, I still get this error!

@jnbn
Copy link
Contributor

jnbn commented Sep 18, 2019

Oh I see.

@muglug can you please tag and release latest commits on master as 5.4.1 ?

@jnbn
Copy link
Contributor

jnbn commented Sep 18, 2019

@hassanazimi can you try using dev-master on your composer for now?

@azimidev
Copy link
Author

azimidev commented Sep 18, 2019

can't do that! composer stops working when updating! My whole app upgrade stuck because of this!

@diegosm
Copy link

diegosm commented Sep 19, 2019

Maybe the problem is only on 'how' it was tagged for packagist.
I used
...
"vimeo/laravel": "dev-master"

and works fine for me until this moment.

@azimidev
Copy link
Author

Well for me when I use

"vimeo/laravel": "dev-master"

and I run composer update, composer hangs and sticks!

@jnbn
Copy link
Contributor

jnbn commented Sep 19, 2019

I suggest deleting your composer.lock and try composer install while keeping vimeo/laravel on dev-master as it is.

@jnbn
Copy link
Contributor

jnbn commented Sep 27, 2019

@muglug can you please tag and release latest commits on master as 5.4.1 ?

Still no support for Laravel 6.

@mkuzmych
Copy link

mkuzmych commented Nov 4, 2019

Same problem:
- Installation request for vimeo/laravel ^5.4 -> satisfiable by vimeo/laravel[5.4.0].
- Conclusion: remove laravel/framework v6.4.1
- Conclusion: don't install laravel/framework v6.4.1
- vimeo/laravel 5.4.0 requires illuminate/support ^5.8 -> satisfiable by laravel/framework[5.8.x-dev], illuminate/support[5.8.x-dev, v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.33, v5.8.34, v5.8.35, v5.8.4, v5.8.8, v5.8.9].

Is there any issue? Thanks!

@mkuzmych
Copy link

mkuzmych commented Nov 4, 2019

@hassanazimi hassanazimi are You found a solution of this problem?

@mkuzmych
Copy link

mkuzmych commented Nov 4, 2019

My fix for problem:
in composer.json:
"minimum-stability": "dev", "prefer-stable": true
then
/usr/local/bin/composer require vimeo/laravel:dev-master

@azimidev
Copy link
Author

azimidev commented Nov 5, 2019

@uapixart Thanks your solution worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants