Support for aliases?

[jsanahuja]

Psalm does not seem to take PHP aliases into account. Examples:

• count: https://psalm.dev/r/9d70fdf31d
• sizeof: https://psalm.dev/r/8a26a0a0f9

Is this the expected behavior?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/9d70fdf31d

<?php

$str = "1|2|3|4|5|6";
$parts = explode('|', $str);

if (count($parts) != 6) {
    die('6 parts required!');
}

[$a, $b, $c, $d, $e, $f] = $parts;

print_r([$a, $b, $c, $d, $e, $f]);

Psalm output (using commit c8f7b7e):

No issues!

https://psalm.dev/r/8a26a0a0f9

<?php

$str = "1|2|3|4|5|6";
$parts = explode('|', $str);

if (sizeof($parts) != 6) {
    die('6 parts required!');
}

[$a, $b, $c, $d, $e, $f] = $parts;

print_r([$a, $b, $c, $d, $e, $f]);

Psalm output (using commit c8f7b7e):

INFO: PossiblyUndefinedIntArrayOffset - 10:6 - Possibly undefined array key

INFO: PossiblyUndefinedIntArrayOffset - 10:10 - Possibly undefined array key

INFO: PossiblyUndefinedIntArrayOffset - 10:14 - Possibly undefined array key

INFO: PossiblyUndefinedIntArrayOffset - 10:18 - Possibly undefined array key

INFO: PossiblyUndefinedIntArrayOffset - 10:22 - Possibly undefined array key

[weirdan]

Not expected as in 'incorrect'.

[weirdan]

Aliases reference: https://www.php.net/manual/en/aliases.php

[orklah]

Adding sizeof here:

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php

Line 1498 in a796f21

return self::hasNonEmptyCountOrStrlenEqualityCheck($conditional, $min_count, ['count']);

should be enough :)

[jsanahuja]

May I send a pull request fixing it @weirdan and @orklah?

[weirdan]

You absolutely can.

[jsanahuja]

Done, thanks!