Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement by-ref closure use analysis #10419

Merged
merged 4 commits into from
Dec 3, 2023
Merged

Implement by-ref closure use analysis #10419

merged 4 commits into from
Dec 3, 2023

Conversation

danog
Copy link
Collaborator

@danog danog commented Nov 28, 2023

No description provided.

@danog danog added the release:feature The PR will be included in 'Features' section of the release notes label Nov 28, 2023
@danog danog marked this pull request as ready for review November 28, 2023 12:26
@danog danog requested a review from orklah November 28, 2023 12:26
@danog
Copy link
Collaborator Author

danog commented Nov 28, 2023 •
edited

@orklah / @weirdan updating the baseline on https://github.com/psalm/endtoend-test-psl should fix, but I don't have push access, could someone do that after merging?

@orklah
Copy link
Collaborator

orklah commented Dec 2, 2023

I don't have write permissions either. Should I still merge this?

@danog
Copy link
Collaborator Author

danog commented Dec 3, 2023

Yeah @orklah let's merge this, let's just tag @weirdan once more so he gives us both push permissions when he finds some time :)

@weirdan
Copy link
Collaborator

weirdan commented Dec 3, 2023

@danog @orklah sorry for my recent hiatus. I've added both of you to the new team in psalm org, and granted that team maintain permissions on all the org repos. Additionally, you're both are that team managers, so you can add more people should the need arise.

@danog
Copy link
Collaborator Author

danog commented Dec 3, 2023

Thanks @weirdan, no problem!)

@orklah can you merge this now that tests are passing? :)

Also, could you also tag a release after merging #10439 and #10431 as well? I believe the feature present in this PR would be very much appreciated :)

@orklah
Copy link
Collaborator

orklah commented Dec 3, 2023

The 2 branches have conflicts, can you resolve them?

@danog
Copy link
Collaborator Author

danog commented Dec 3, 2023

@orklah Done!

@orklah orklah merged commit 1cca558 into vimeo:5.x Dec 3, 2023
50 checks passed
@orklah
Copy link
Collaborator

orklah commented Dec 3, 2023

Thanks!

tcarrio pushed a commit to open-feature/php-sdk that referenced this pull request Dec 4, 2023
@renovate
chore(deps): update dependency vimeo/psalm to ~5.17.0 (#111)
ea4fed3 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vimeo/psalm](https://togithub.com/vimeo/psalm) | `~5.16.0` ->
`~5.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.17.0`](https://togithub.com/vimeo/psalm/releases/tag/5.17.0)

[Compare
Source](https://togithub.com/vimeo/psalm/compare/5.16.0...5.17.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Implement by-ref closure use analysis by
[@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10419

##### Fixes

- Update MongoDB stubs for 1.17 by
[@&#8203;alcaeus](https://togithub.com/alcaeus) in
[vimeo/psalm#10402
- Fix backtick analysis by [@&#8203;danog](https://togithub.com/danog)
in
[vimeo/psalm#10409
- Declare we do not support document highlighting by
[@&#8203;tm1000](https://togithub.com/tm1000) in
[vimeo/psalm#10408
- update define types to be correct by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[vimeo/psalm#10423
- Fix return type of DOMXPath::query by
[@&#8203;nielsdos](https://togithub.com/nielsdos) in
[vimeo/psalm#10443
- Fix CLI -r error by [@&#8203;kkmuffme](https://togithub.com/kkmuffme)
in
[vimeo/psalm#10442
- Use correct file path while adding unused suppressions for virtual
\__… by [@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10434
- Restore support for null coalesce on match expressions by
[@&#8203;tscni](https://togithub.com/tscni) in
[vimeo/psalm#10422
- Fix static magic method pureness not being inherited from traits by
[@&#8203;tscni](https://togithub.com/tscni) in
[vimeo/psalm#10429
- Fix POSIX only detection of absolute paths by
[@&#8203;rarila](https://togithub.com/rarila) in
[vimeo/psalm#10441
- Emit UnusedPsalmSuppress issues for suppressed issues already removed
by [@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10431
- Use keyed arrays when assigning literal union keys & assertion fixes
by [@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10439

##### Internal changes

- use branch name to randomize tests to ensure test dependencies will
error by [@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[vimeo/psalm#10424

#### New Contributors

- [@&#8203;nielsdos](https://togithub.com/nielsdos) made their first
contribution in
[vimeo/psalm#10443

**Full Changelog**:
vimeo/psalm@5.16.0...5.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/php-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tcarrio pushed a commit to open-feature/php-sdk that referenced this pull request Dec 5, 2023
@renovate @tcarrio
chore(deps): update dependency vimeo/psalm to ~5.17.0 (#111)
1a338b7 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vimeo/psalm](https://togithub.com/vimeo/psalm) | `~5.16.0` ->
`~5.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.17.0`](https://togithub.com/vimeo/psalm/releases/tag/5.17.0)

[Compare
Source](https://togithub.com/vimeo/psalm/compare/5.16.0...5.17.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Implement by-ref closure use analysis by
[@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10419

##### Fixes

- Update MongoDB stubs for 1.17 by
[@&#8203;alcaeus](https://togithub.com/alcaeus) in
[vimeo/psalm#10402
- Fix backtick analysis by [@&#8203;danog](https://togithub.com/danog)
in
[vimeo/psalm#10409
- Declare we do not support document highlighting by
[@&#8203;tm1000](https://togithub.com/tm1000) in
[vimeo/psalm#10408
- update define types to be correct by
[@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[vimeo/psalm#10423
- Fix return type of DOMXPath::query by
[@&#8203;nielsdos](https://togithub.com/nielsdos) in
[vimeo/psalm#10443
- Fix CLI -r error by [@&#8203;kkmuffme](https://togithub.com/kkmuffme)
in
[vimeo/psalm#10442
- Use correct file path while adding unused suppressions for virtual
\__… by [@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10434
- Restore support for null coalesce on match expressions by
[@&#8203;tscni](https://togithub.com/tscni) in
[vimeo/psalm#10422
- Fix static magic method pureness not being inherited from traits by
[@&#8203;tscni](https://togithub.com/tscni) in
[vimeo/psalm#10429
- Fix POSIX only detection of absolute paths by
[@&#8203;rarila](https://togithub.com/rarila) in
[vimeo/psalm#10441
- Emit UnusedPsalmSuppress issues for suppressed issues already removed
by [@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10431
- Use keyed arrays when assigning literal union keys & assertion fixes
by [@&#8203;danog](https://togithub.com/danog) in
[vimeo/psalm#10439

##### Internal changes

- use branch name to randomize tests to ensure test dependencies will
error by [@&#8203;kkmuffme](https://togithub.com/kkmuffme) in
[vimeo/psalm#10424

#### New Contributors

- [@&#8203;nielsdos](https://togithub.com/nielsdos) made their first
contribution in
[vimeo/psalm#10443

**Full Changelog**:
vimeo/psalm@5.16.0...5.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/php-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Tom Carrio <tom@carrio.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah Awaiting requested review from orklah

Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danog @orklah @weirdan