Use keyed arrays when assigning literal union keys & assertion fixes

[danog]

No description provided.

[danog]

Generally pretty happy with this, especially with the improvements for adjustTKeyedArrayType.

Some further improvements can be made (regarding the changed test in tests/Loop/ForeachTest.php), but generally, this simply exposes some of the rough edges already present with assertions in keyed arrays, minus the ones already fixed here in adjustTKeyedArrayType.

[orklah]

Great! Seems like a few CI errors slipped in

[danog]

@orklah Should be good to merge, the changes to LanguageServer were due to a previously existing issue already present on master, being revealed by the changes in this PR: https://psalm.dev/r/3ee4768cfa

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/3ee4768cfa

<?php


/**
 * @param array<string, false|list<false|string>|string> $options
 */
function a(array $options): string|null {
        if (isset($options['tcp'])) {
            if (!is_string($options['tcp'])) {
                fwrite(STDERR, 'tcp url should be a string' . PHP_EOL);
                exit(1);
            }
        }
        return $options['tcp'] ?? null;
}

Psalm output (using commit 0e43c44):

ERROR: InvalidReturnStatement - 14:16 - The inferred type 'false|list<false|string>|null|string' does not match the declared return type 'null|string' for a

ERROR: FalsableReturnStatement - 14:16 - The declared return type 'null|string' for a does not allow false, but the function returns 'false|list<false|string>|null|string'

ERROR: InvalidReturnType - 7:29 - The declared return type 'null|string' for a is incorrect, got 'false|list<false|string>|null|string'

[orklah]

erf, this one has conflict again

[danog]

Kek, fixed

[orklah]

Thanks!