-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List refactoring (v6) #8773
List refactoring (v6) #8773
Conversation
…non-empty-array if there are no defined keys
Wew, this PR triggered a huge amount of previously uncovered and broken edge cases, I fixed a bunch of bugs also present in master. |
The HasArrayKey assertion turned out to be completely broken and actually useless, for example when asserting Edit: nevermind it's only really used properly for class strings (still a bit weird though), reverted that part. |
Closing until the master branch becomes the v6, refer to #8820 |
Fixes a bunch of bugs all over the codebase.