-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List refactoring (v6) #8773
Closed
Closed
List refactoring (v6) #8773
Changes from all commits
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
5b33589
Fix array_merge argument unpacking
danog cc4461f
Progress
danog 3f5f98b
Refactoring
danog 98bfe9f
Add note for 5.1 BC break
danog f7527d4
Fix
danog b632871
Remove getGenericArrayType parameter right away, and do not return a …
danog 5797945
Skip test
danog 7683a48
Revert
danog 03c53d7
Deprecate TList and TNonEmptyList
danog 80eab1b
Update
danog 0a3971a
Deprecate TCallableList as well
danog 5bf226d
Cleanup
danog bd9b77d
Cleanup
danog 0345254
Reuse code
danog 61a595b
Cleanup
danog 9a5337d
Switch to Type::getListAtomic
danog d580181
Finalize
danog 1a9edc3
Fix cs
danog 4ceb562
Merge branch 'list_bc_break' into tnon_empty_list_refactoring
danog 3154860
Cleanup
danog cf3a49a
Cleanup
danog d2e0d31
Cleanup
danog ab1a901
Cleanup
danog 5b12042
Cleanup
danog b43207e
Cleanup
danog 415d103
Cleanup
danog 61cce1b
Cleanup
danog 668afa9
Cleanup
danog 956fa44
Cleanup
danog fca60dc
Cleanup
danog 864a764
Cleanup
danog 120ba1f
Refactoring
danog 0a20c10
Refactoring
danog e2da9c9
Cleanup
danog 3f710a8
Cleanup
danog 546f2b3
Cleanup
danog 51e6b11
Cleanup
danog 700e066
Fixes
danog 1c32a22
Fix
danog c823c87
Cleanup
danog 45c26d0
Merge remote-tracking branch 'origin/master' into tnon_empty_list_ref…
danog d0d7c46
Fix
danog 0f99365
Cleanup
danog a964715
Update
danog 582a785
Fix
danog 34825fc
Fix
danog 156d629
Fix
danog a342a26
Fix
danog 99bdc2f
Cleanup
danog 65f849a
Cleanup
danog 95e0614
Off-by-one fun
danog 65886c9
Fixes
danog c0b0dbc
Fix bug
danog 3178836
Fixes
danog e7f2fdd
Fix
danog e89609b
Fixes
danog 0107a34
Cleanup logic
danog abbaf88
Improve assertions
danog a6a6595
Fix
danog 4f10cd3
Cleanup
danog 9a0ecf7
Fixes
danog 909edb4
Fixes
danog 2b9512e
Generate properly shaped lists when appending
danog 0542b0e
Fix list templates
danog 163330c
Merge remote-tracking branch 'o/master' into tnon_empty_list_refactoring
danog 389c6e6
Revert weird legacy logic
danog 0bb70b3
Update
danog 8a4ba6d
Cleanup
danog c156807
Update
danog 42380db
Cleanup
danog e821109
Fixes
danog 2b0e979
Fixes
danog d24a243
Fix
danog 8fc161c
Merge remote-tracking branch 'origin/master' into tnon_empty_list_ref…
danog 6c3ffa2
Fix logic
danog 03fc544
Fix
danog e529402
Fix
danog 412d3c9
Simplify
danog e50b351
Cleanup
danog f89a3c9
Fix
danog 54600ca
Fixup
danog 4bf7087
Fixes
danog 7e571f4
Fixes
danog b8ffb31
Possible fix
danog 096b390
Cleanup
danog a0bf4cf
Fixes
danog 8aecadd
Fixes
danog dead1be
Fix
danog c96a44d
Revert
danog a5df566
Fixes
danog b07aba9
Fix
danog e628c7b
Fixes
danog f015c50
Fixes
danog 4847165
Fixes
danog c894b89
Fixes
danog 550a7aa
Fixes
danog 8f2a8c0
Fixes
danog d4df856
Cleanup
danog c802213
Fixes
danog 59ab73f
Fixes
danog 5f291af
Fixes
danog c05ce2d
Fixes
danog 709324b
Fixes
danog 4a77e83
Fix
danog c4c3016
Fix
danog abe722d
Fix array_key_exists with constants
danog 23b0ac0
Hack
danog 55edadc
Merge remote-tracking branch 'origin/master' into tnon_empty_list_ref…
danog 78d64e3
Fix
danog 3ce782f
Fixes
danog c24e6a9
Fix
danog 4c47d50
Update
danog a154d96
Keep HasArrayKey logic only for class strings
danog 4e10f16
cs-fix
danog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to follow semver and name that version 6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually was hoping to get this merged by Psalm 5.0 given psalm/psalm.dev@dbe30c0, that description is outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not gonna make it though, I'd still love to get at least #8728 merged so people already stop using TList and switch over to keyed lists in time for 5.1