Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body.upload.upload_link is null sometimes #325

Open
jongotlin opened this issue Dec 8, 2022 · 0 comments · May be fixed by #327
Open

body.upload.upload_link is null sometimes #325

jongotlin opened this issue Dec 8, 2022 · 0 comments · May be fixed by #327

Comments

@jongotlin
Copy link

jongotlin commented Dec 8, 2022

For an unknown reason I've got null as upload_link from Vimeo a few times.

$url = $attempt['body']['upload']['upload_link'];

This breaks the code here:

$client = $this->_tus_client_factory->getTusClient($base_url, $url);

Vimeo\Upload\TusClientFactory::getTusClient(): Argument #2 ($url) must be of type string, null given, called in /var/task/vendor/vimeo/vimeo-api/src/Vimeo/Vimeo.php on line 599

We should solve it by either throw an exception, allow null or cast to string. I have too little knowledge in this process to know what's best but I can sure open a PR if someone decides which way to go.

This was referenced Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant