Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload progress comparison won't work #53

Closed
Gwildor opened this issue Jan 20, 2015 · 1 comment
Closed

Upload progress comparison won't work #53

Gwildor opened this issue Jan 20, 2015 · 1 comment

Comments

@Gwildor
Copy link

Gwildor commented Jan 20, 2015

In the _perform_upload method, attempts are made to upload a chunk of the video (or the complete video in one go, I'm not quite sure about that), and a request is made to check the progress. The goal is to continue with other chunks if something happened, like a timeout, but the check to see if it needs to do a new attempt can't possibly work because it's comparing two different types.

See

while last_byte < size:
for the line which does the faulty check. Here, last_byte is a str because it comes from a header of the progress request, while size is a long. An easy fix would be to simply run int() over last_byte.

@sclm sclm closed this as completed in 4bda1ed Jan 20, 2015
@sclm
Copy link
Contributor

sclm commented Jan 20, 2015

Good catch @Gwildor! I've added that to the function that checks the progress and it should be an int-int comparision now.

Feel free to check it out and make sure it's working for you and your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants