Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Don't create extra drawable if roundBackgrond == false #34

Closed
vinc3m1 opened this issue Apr 12, 2014 · 2 comments
Closed

Don't create extra drawable if roundBackgrond == false #34

vinc3m1 opened this issue Apr 12, 2014 · 2 comments
Assignees
@vinc3m1

Comments

@vinc3m1
Copy link
Owner

vinc3m1 commented Apr 12, 2014

No description provided.

@vinc3m1 vinc3m1 self-assigned this Apr 12, 2014
vinc3m1 added a commit that referenced this issue Apr 13, 2014
@vinc3m1
only convert background drawable if mutate_background is true
6d734ca 
also updated api
#34
@vinc3m1
Copy link
Owner Author

vinc3m1 commented Apr 13, 2014

@technicalcycling mind checking out if this change fixes the extra background Drawable?

Technically if you used a BitmapDrawable for the background, RoundedDrawable would re-use the exiting bitmap, so this would only avoid an extra bitmap in the case of colordrawables, etc. But this does still remove the extra work involved adding borders and rounding the background if it's already rounded.

@vinc3m1
Copy link
Owner Author

vinc3m1 commented Apr 13, 2014

Note the API has changed slightly
round_background -> mutate_background
is_oval -> oval

@vinc3m1 vinc3m1 closed this as completed May 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vinc3m1 vinc3m1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vinc3m1