Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #343

Merged
merged 8 commits into from
Jan 22, 2019
Merged

Minor fixes #343

merged 8 commits into from
Jan 22, 2019

Conversation

kazu-yamamoto
Copy link
Collaborator

This PR exposes necessary types (no haddock warnings anymore), updates document and fixes coding style.

@kazu-yamamoto
Copy link
Collaborator Author

Also this fixes #228.

@ocheron
Copy link
Contributor

ocheron commented Jan 22, 2019

I don't think it's a good idea to expose the internals of TLSParams.
Users don't need to provide their own instances.

@kazu-yamamoto
Copy link
Collaborator Author

The original code is exporting the name TLSParams but not its methods.

  1. The original approach
  • Haddock warning: getTLSCommonParams getTLSRole doHandshake doHandshakeWith
  • TLSParams connects contextNew and ClientParams nicely
  1. Stopping TLSParams, too
  • Haddock warning: TLSParams
  • No clue to connect contextNew and ClientParams

I think that 2) is not good. So, I will take the original approach.

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jan 22, 2019
@kazu-yamamoto kazu-yamamoto merged commit 2fba870 into haskell-tls:master Jan 22, 2019
@kazu-yamamoto kazu-yamamoto deleted the minor-fixes branch January 22, 2019 23:03
@kazu-yamamoto
Copy link
Collaborator Author

Merged. Thank you for your review.

@ocheron
Copy link
Contributor

ocheron commented Jan 27, 2019

Could you also remove CommonParams and Role, and revert the change to Network.TLS.Context ?

Weeds exported
* Network.TLS.Context
  - doHandshake
  - doHandshakeWith
  - getTLSCommonParams
  - getTLSRole

kazu-yamamoto added a commit to kazu-yamamoto/hs-tls that referenced this pull request Jan 28, 2019
@kazu-yamamoto
Copy link
Collaborator Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants