Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort ciphersuites based on hardware-acceleration support #439

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Sort ciphersuites based on hardware-acceleration support #439

merged 1 commit into from
Jul 21, 2020

Conversation

ocheron
Copy link
Contributor

@ocheron ocheron commented Jul 19, 2020

Uses runtime flags provided by cryptonite to define AEAD cipher preference based on hardware-acceleration support.

The main lists of ciphersuites _default, _all and _strong are modified, most application code will directly get this.

A version of those lists without dynamic ordering is provided in case application code needs it.
This gives almost identical order to what was there previously, except the position of CCM ciphers is slightly ajusted.

Debug tools are extended to show the optimizations that are active.

Closes #369.

@kazu-yamamoto kazu-yamamoto self-requested a review July 21, 2020 00:23
Copy link
Collaborator

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 8c60b03 into haskell-tls:master Jul 21, 2020
@kazu-yamamoto
Copy link
Collaborator

Merged.

@ocheron ocheron deleted the cpu-info branch July 22, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order ciphersuites dynamically based on optimizations
2 participants