Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace composer.json #2

Closed
k1sul1 opened this issue Aug 17, 2017 · 0 comments
Closed

Replace composer.json #2

k1sul1 opened this issue Aug 17, 2017 · 0 comments

Comments

@k1sul1
Copy link
Contributor

k1sul1 commented Aug 17, 2017

As plugins and themes are managed by Composer, they have to be tracked in composer.json.

Seravo/wordpress has one already though. It installs plugins that we might not want, and doesn't install plugins that we might want.

Replace it with Composer post-install-cmd or in vagrant up.

I've no knowledge about whether or not you can prompt in scripts that run in post-install-cmd, and replacing a core file isn't something that I want to do without asking the user, so vagrant up might be a better place.

@k1sul1 k1sul1 closed this as completed in ed0f0d2 Aug 18, 2017
k1sul1 added a commit that referenced this issue Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant