Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking query(#hashtags) as input from user #3

Open
vinitshahdeo opened this issue Oct 2, 2019 · 16 comments · May be fixed by #13
Open

Taking query(#hashtags) as input from user #3

vinitshahdeo opened this issue Oct 2, 2019 · 16 comments · May be fixed by #13
Labels
enhancement good first issue Send your first PR hacktoberfest Send PR and earn a free t-shirt help wanted up-for-grabs Solve the issue and raise your first PR

Comments

@vinitshahdeo
Copy link
Owner

vinitshahdeo commented Oct 2, 2019

Currently, the query is hardcoded in jobtweets.py i.e.

tweets = api.get_tweets(query = 'Job Opportunities', count = 500)

Taking the input for query (i.e. #hashtag) from the user through CLI seems better!

Question to answer?

Can we take input as a comma-separated string for processing multiple hashtags at a time?

Enter hashtags: jobs, openings, job opportunities

Note:

  • Make changes only in jobtweets.py
  • Your PR should not break the functionality of the existing code.
  • Add me( @vinitshahdeo ) as reviewer
  • Do not make any changes to other files.
@vinitshahdeo vinitshahdeo added hacktoberfest Send PR and earn a free t-shirt enhancement good first issue Send your first PR help wanted labels Oct 2, 2019
@vinitshahdeo vinitshahdeo pinned this issue Oct 2, 2019
@agarwalrounak
Copy link

Hi Vinit, I would like to take this up.

@vinitshahdeo
Copy link
Owner Author

@agarwalrounak Please go ahead!

@adithya-sn
Copy link

Could have probably been done in a simpler way. Here's my attempt :)
#7

@vinitshahdeo vinitshahdeo added the up-for-grabs Solve the issue and raise your first PR label Oct 4, 2019
@roidsaja roidsaja linked a pull request Oct 8, 2019 that will close this issue
@Aravind22
Copy link

Is this still open?

@n150705
Copy link

n150705 commented Oct 19, 2019

In CLI while entering tags is there a space character after the comma symbol?

@n150705
Copy link

n150705 commented Oct 19, 2019

Can I print the results of positive, negative and neutral for each of the tags?

@vinitshahdeo
Copy link
Owner Author

Yeah that would be great!

@vinitshahdeo
Copy link
Owner Author

CHECK OUT THIS LINK FOR LIVE CORONA UPDATES

Hello everyone,

I hope you are staying safe at your home and enjoying the contribution to your awesome open source projects. I've created a web app to display the latest corona updates, please check here.

👋 DO THE FIVE: Help stop coronavirus

  1. HANDS: Wash them often
  2. ELBOW: Cough into it
  3. FACE: Don't touch it
  4. SPACE: Keep safe distance
  5. HOME: Stay if you can

COVID-19: Stay HomeStay Safe

  • Avoid Handshakes 🤝 ❌
  • Do Namastey 🙏 ✔️

PS: I know it's off-topic but Yes, COVID-19 everyone's talking about. Please stay safe at your home and enjoy contributing to your projects.

@vinitshahdeo
Copy link
Owner Author

Hello everyone,

Hope everyone's staying safe at home.

Do check out my latest COVID-19 😷Tracker | INDIA 🇮🇳

Checkout my open letter to all the contributors here. ❤️

COVID-19 Tracker by Vinit Shahdeo


I've just revamped the UI(WIP). You can check the old website here. Consider leaving a star here. ⭐
(To be open-sourced pretty soon.)

GitHub stars - COVID-19 Vinit Shahdeo

@Defcon27
Copy link

Is this still open since #13 has fixed the issue

@imanishbarnwal
Copy link

Hello, @vinitshahdeo I want to take this issue.

@satyam-52
Copy link

Hello, @vinitshahdeo can I take this issue?

@Johnkayode
Copy link

Hello @vinitshahdeo #46 I updated some old methods and also implementated the CLI input feature

@meghasarkar1289
Copy link

Hello, @vinitshahdeo can I take this issue?

@leyohla
Copy link

leyohla commented Oct 12, 2022

Hi, is this open?

@Raish07
Copy link

Raish07 commented May 27, 2023

hashtags = input("Enter hashtags (comma-separated): ")
query = hashtags.replace(" ", "").split(",")
tweets = api.get_tweets(query=query, count=500) hii @vinitshahdeo here i have made a new a variable inside def main() method to collect hashtags from user and then i am removing any spaces amongst them to maintain the fundamental feature of hashtags in general and then i am splitting each hashtag individually by using (',') as delimiter and storing this value in query variable and after passing this into tweets variable to get tweets on the basis of provided hashtags. Let me know if i can make any other changes regarding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Send your first PR hacktoberfest Send PR and earn a free t-shirt help wanted up-for-grabs Solve the issue and raise your first PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.