Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for scheduled update time #27

Closed
vinteo opened this issue Jun 29, 2019 · 3 comments · Fixed by #52
Closed

Add config for scheduled update time #27

vinteo opened this issue Jun 29, 2019 · 3 comments · Fixed by #52
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@vinteo
Copy link
Owner

vinteo commented Jun 29, 2019

Currently its hardcoded at 5 seconds. Could probably bump it up to 10 secs, but ideally it should be a config option

@vinteo vinteo added enhancement New feature or request good first issue Good for newcomers labels Jun 29, 2019
@maorcc
Copy link

maorcc commented May 27, 2020

I believe that many people are seeing the following Warnings in the Core logs.

2020-05-27 16:48:53 WARNING (MainThread) [homeassistant.components.switch] Updating hass_opensprinkler switch took longer than the scheduled update interval 0:00:05
2020-05-27 16:48:53 WARNING (MainThread) [homeassistant.components.binary_sensor] Updating hass_opensprinkler binary_sensor took longer than the scheduled update interval 0:00:05
2020-05-27 16:48:53 WARNING (MainThread) [homeassistant.components.sensor] Updating hass_opensprinkler sensor took longer than the scheduled update interval 0:00:05

Would increasing the update time resolve this?

@travisghansen
Copy link
Collaborator

We’re working on a massive rewrite currently. I’m guessing one of the biggest reasons that happened is every entity was independently hitting the opensprinkler api. The code is now updated to get the status of everything in a single api call across all entities. For me this change cut the api requests down from probably close to 100+ every 5 seconds to 1 every 5 seconds.

The new branch isn’t quite ready yet but it’s a massive improvement in several ways. We hope to get it included into hass core as well.

@vinteo
Copy link
Owner Author

vinteo commented May 27, 2020

Yea I think with the next version this is probably not needed anymore tbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants