Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: make allowed tasks not exact match #5

Closed
virgilwashere opened this issue Oct 19, 2019 · 1 comment
Closed

Feature: make allowed tasks not exact match #5

virgilwashere opened this issue Oct 19, 2019 · 1 comment
Labels
help wanted This issue or pull request needs extra attention. 🎃 hacktoberfest Issues available for Hacktoberfest (hacktoberfest.digitalocean.com) ⏸️ on hold Progress on this issue or PR is currently suspended. 🎇 enhancement Improving an already-existing feature.

Comments

@virgilwashere
Copy link
Owner

Currently, the requested task has to be an exact match to the array elements.

$task = urldecode($_GET['task']);
if (!in_array($task, $allowedCmds)) {
    http_response_code(403);
    die("Command {$task} is not allowed!");
}

I would like to make the check for the base command only

mautic:segments:update

vs

mautic:segments:update --max-contacts=300 --batch-limit=300 --quiet

@virgilwashere virgilwashere added 💻 console command This issue is about a console command. help wanted This issue or pull request needs extra attention. labels Oct 19, 2019
@virgilwashere virgilwashere added 🎃 hacktoberfest Issues available for Hacktoberfest (hacktoberfest.digitalocean.com) 🎇 enhancement Improving an already-existing feature. and removed 💻 console command This issue is about a console command. labels Oct 28, 2019
@stale
Copy link

stale bot commented Dec 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the ⏸️ on hold Progress on this issue or PR is currently suspended. label Dec 1, 2019
@stale stale bot closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This issue or pull request needs extra attention. 🎃 hacktoberfest Issues available for Hacktoberfest (hacktoberfest.digitalocean.com) ⏸️ on hold Progress on this issue or PR is currently suspended. 🎇 enhancement Improving an already-existing feature.
Projects
None yet
Development

No branches or pull requests

1 participant