virtinst: allow adding host block devices to LXC containers

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

man/virt-install.pod

@@ -1230,6 +1230,10 @@ Network device (in LXC container).
 
 Character device (in LXC container).
 
+=item B<--hostdev /dev/sdf,type=storage>
+
+Block device (in LXC container).
+
 =back
 
 Use --hostdev=? to see a list of all available sub options. Complete details at L<https://libvirt.org/formatdomain.html#elementsHostDev>

tests/xmlparse-xml/change-hostdevs-in.xml

@@ -53,5 +53,10 @@
         <char>/dev/net/tun</char>
       </source>
     </hostdev>
+    <hostdev mode="capabilities" type="storage" managed="yes">
+      <source>
+        <block>/dev/sdf</block>
+      </source>
+    </hostdev>
   </devices>
 </domain>

tests/xmlparse-xml/change-hostdevs-out.xml

@@ -56,5 +56,10 @@
         <char>/dev/null</char>
       </source>
     </hostdev>
+    <hostdev mode="capabilities" type="storage" managed="yes">
+      <source>
+        <block>/dev/fd0</block>
+      </source>
+    </hostdev>
   </devices>
 </domain>

tests/xmlparse.py

@@ -697,6 +697,7 @@ def testAlterHostdevs(self):
         dev4 = guest.devices.hostdev[3]
         dev5 = guest.devices.hostdev[4]
         dev6 = guest.devices.hostdev[5]
+        dev7 = guest.devices.hostdev[6]
 
         check = self._make_checker(dev1)
         check("type", "usb", "foo", "usb")
@@ -739,6 +740,10 @@ def testAlterHostdevs(self):
         check = self._make_checker(dev6)
         check("type", "misc")
         check("misc_char", "/dev/net/tun", "/dev/null")
+
+        check = self._make_checker(dev7)
+        check("type", "storage")
+        check("storage_block", "/dev/sdf", "/dev/fd0")
         self._alter_compare(guest.get_xml_config(), outfile)
 
     def testAlterWatchdogs(self):

virtinst/cli.py

@@ -2785,6 +2785,9 @@ def set_name_cb(self, inst, val, virtarg):
         elif inst.type == "misc":
             inst.mode = "capabilities"
             inst.misc_char = val
+        elif inst.type == "storage":
+            inst.mode = "capabilities"
+            inst.storage_block = val
         else:
             val = NodeDevice.lookupNodedevFromString(inst.conn, val)
             inst.set_from_nodedev(val)

virtinst/devices/hostdev.py

@@ -138,3 +138,6 @@ def _get_default_domain(self):
 
     # type=misc handling
     misc_char = XMLProperty("./source/char")
+
+    # type=misc handling
+    storage_block = XMLProperty("./source/block")