Moreiraj/vir 794 race condition when loading settings in #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In addition setValue input names were updated to the expected setFieldValue to be more intuitive
This change prevents onClick events from being fired with stale data
- Previously on submission all values of the form would be reset to the initial values.
…onstant. initialValues is now only declared once it's dependent props have been loaded
Without the boolean casting, the `data` object would be sent as props when ready is truthy. This lead to the issue of referential equality being used for both useEffects, causing many additional renders.
|
This needs to be based of the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State.account.datawas previously not considered to determine the value of the ready prop. This lead to issues where other components that depended on that data, like the sample creation page, would attempt to access it before it had been loaded.