Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly Added Capability #486

Merged

Conversation

AmbientOSX
Copy link
Contributor

...brings back the trashcan, removes some flyout offsets since we're using advanced categories and should fix tooltips and mutator callout origins for Blockly.

@kadst43 @BrettASwift @nmarshak1337

…ch should fix tooltips and mutator callout origins for Blockly).
var negateOverlap = 35;
// SJF: Overlap not present in Blockly with categories enabled

// var negateOverlap = 35;
Blockly.updateToolbox( xml );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the only thing that's executing in this function is Blockly.updateToolbox( xml ), does it make more sense to comment out the entire cleanUpdateToolbox function, and replace it with updateToolbox?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it incase we switch back to using basic blockly with no categories or build our own categories or something. Good point though :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. Might be better to remove the cruft, and put in a comment saying something like "If you ever want to change back to the simple UI, look in github back to thus-and-such a date/branch."

On a related note, though... are level designers going to have the option to switch between the two UIs, or do we have to pick one and stick with it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you need to pick one and stick with it for the whole "game" - once it loads it must stay in a certain configuration. Haven't explored what reloading might mean/entail but I suspect it isn't pretty.

AmbientOSX pushed a commit that referenced this pull request Apr 8, 2015
…apability-support

Blockly Added Capability
@AmbientOSX AmbientOSX merged commit be8d366 into branch/mars-game-development Apr 8, 2015
@AmbientOSX AmbientOSX deleted the branch/blockly-capability-support branch August 12, 2015 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants