-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter system #172
Filter system #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm going to do some testing on the server this afternoon and then I'll approve. I left a couple of suggestions for you, but they shouldn't hold back the PR. Feel free to make the changes if they make sense to you
…nd resolve PR issues.
…ty action are triggered for trrack
|
Things for me to double check:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I noted a couple issues in my comment above that might warrant some further investigation
Pretty sure this is because the main interface doesn't "reload" until you click back to render it. But I'll take a closer look on next PR. |
Closes #77