Skip to content

Commit

Permalink
use offsetX & offsetY instead of x & y to get relative positions (#445)
Browse files Browse the repository at this point in the history
* use offsetX & offsetY instead of x & y to get relative positions

* drop event if sanity check fails
  • Loading branch information
gnavvy committed Mar 22, 2017
1 parent 2248cd2 commit 5fefcf3
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions src/react/deckgl.js
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ export default class DeckGL extends React.Component {

// Route events to layers
_onClick(event) {
const {x, y} = event;
// use offsetX|Y for relative position to the container, drop event if falsy
if (!event || !event.event || !Number.isFinite(event.event.offsetX)) {
return;
}
const {event: {offsetX: x, offsetY: y}} = event;
const selectedInfos = this.layerManager.pickLayer({x, y, mode: 'click'});
if (selectedInfos.length) {
const firstInfo = selectedInfos.find(info => info.index >= 0);
Expand All @@ -130,7 +134,10 @@ export default class DeckGL extends React.Component {

// Route events to layers
_onMouseMove(event) {
const {x, y} = event;
if (!event || !event.event || !Number.isFinite(event.event.offsetX)) {
return;
}
const {event: {offsetX: x, offsetY: y}} = event;
const selectedInfos = this.layerManager.pickLayer({x, y, mode: 'hover'});
if (selectedInfos.length) {
const firstInfo = selectedInfos.find(info => info.index >= 0);
Expand Down

0 comments on commit 5fefcf3

Please sign in to comment.