-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Content and Polish for Whats New #3001
Conversation
+ `BitmapLayer` is moved to `@deck.gl/layers`. | ||
+ `MeshLayer` is renamed to `SimpleMeshLayer` and moved to `@deck.gl/mesh-layers`. | ||
+ `TileLayer` and `TripsLayer` are moved to `@deck.gl/geo-layers`. | ||
- ` @deck.gl/core` is moved from `dependencies` to `devDependencies` for all submodules. This will reduce the runtime error caused by installing multiple copies of the core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space before @deck.gl/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That extra space is actually on purpose. Without it, the markdown->website parser interprets the content as an email address, sticks a mailto:
in front, and screws up the code-style formatting. Kinda hacky, but its docs and I saw this same strategy already in use elsewhere.
<p><i>H3HexagonLayer</i></p> | ||
</td> | ||
<td> | ||
<img height=200 src="https://raw.github.com/uber-common/deck.gl-data/master/images/whats-new/h3-cluster-layer.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking we can make a better demo to replace this one. But I need know where to get the H3 indexes in order to generate the clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we can/should tackle before 7.0? On one hand, I'm all for making a great impression in our Whats New docs with nice demo images. On the other hand, we can pretty easily update this later.
For #2892