Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Content and Polish for Whats New #3001

Merged
merged 2 commits into from
Apr 19, 2019
Merged

More Content and Polish for Whats New #3001

merged 2 commits into from
Apr 19, 2019

Conversation

tgorkin
Copy link
Contributor

@tgorkin tgorkin commented Apr 18, 2019

For #2892

  • Add more gifs and images for new layers
  • Add glTF section
  • Fix formatting

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.483% when pulling bb449d8 on tgorkin/whats-new into ec7fe2b on master.

@tgorkin tgorkin added this to the 7.0.0 milestone Apr 18, 2019
+ `BitmapLayer` is moved to `@deck.gl/layers`.
+ `MeshLayer` is renamed to `SimpleMeshLayer` and moved to `@deck.gl/mesh-layers`.
+ `TileLayer` and `TripsLayer` are moved to `@deck.gl/geo-layers`.
- ` @deck.gl/core` is moved from `dependencies` to `devDependencies` for all submodules. This will reduce the runtime error caused by installing multiple copies of the core.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra space before @deck.gl/*

Copy link
Contributor Author

@tgorkin tgorkin Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That extra space is actually on purpose. Without it, the markdown->website parser interprets the content as an email address, sticks a mailto: in front, and screws up the code-style formatting. Kinda hacky, but its docs and I saw this same strategy already in use elsewhere.

<p><i>H3HexagonLayer</i></p>
</td>
<td>
<img height=200 src="https://raw.github.com/uber-common/deck.gl-data/master/images/whats-new/h3-cluster-layer.png" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking we can make a better demo to replace this one. But I need know where to get the H3 indexes in order to generate the clusters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something we can/should tackle before 7.0? On one hand, I'm all for making a great impression in our Whats New docs with nice demo images. On the other hand, we can pretty easily update this later.

@tgorkin tgorkin merged commit caeff6d into master Apr 19, 2019
@jianhuang01 jianhuang01 deleted the tgorkin/whats-new branch April 19, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants