Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0 Release Checklist #2892

Closed
5 of 11 tasks
tgorkin opened this issue Apr 2, 2019 · 8 comments
Closed
5 of 11 tasks

7.0 Release Checklist #2892

tgorkin opened this issue Apr 2, 2019 · 8 comments
Assignees
@tgorkin
Milestone
7.0.0

Comments

@tgorkin
Copy link
Contributor

tgorkin commented Apr 2, 2019 •
edited by jianhuang01
Loading

Testing procedure

  • access staged doc website
  • go through all examples
  • verify functionality in control panels
  • look for console errors/warnings
  • add results of testing as comments on this issue
@tgorkin tgorkin self-assigned this Apr 3, 2019
@Pessimistress
Copy link
Collaborator

Pessimistress commented Apr 5, 2019 •
edited
Loading

@tsherif

@Pessimistress Pessimistress reopened this Apr 5, 2019
@tsherif
Copy link
Contributor

tsherif commented Apr 5, 2019

The problem is that we have several versions of isWebGL2. The broken one is https://github.com/uber/luma.gl/blob/master/modules/webgl-state-tracker/src/utils/utils.js#L10-L13

It breaks after the gl constant replacement. I'll remove that function use the one in webgl/webgl-utils everywhere: https://github.com/uber/luma.gl/blob/master/modules/webgl/src/webgl-utils/webgl-checks.js#L12-L19

@tgorkin
Copy link
Contributor Author

tgorkin commented Apr 8, 2019 •
edited by jianhuang01
Loading

Testing results with Firefox 66.0.2 (64-bit) on MacOSX.
Summary:

General warnings on most pages:

  • Error: WebGL warning: getContext: Disallowing antialiased backbuffers due to blacklisting.
  • Error: WebGL warning: texImage2D: Alpha-premult and y-flip are deprecated for non-DOM-Element uploads.
  • Error: WebGL warning: texSubImage2D: Alpha-premult and y-flip are deprecated for non-DOM-Element uploads.
  • luma: Attribute.instanced is deprecated and will be removed in a later version. Use undefined instead
  • luma: accessor size mismatch
  • luma: Buffer.type is deprecated and will be removed in a later version. Use Buffer.accessor.type instead
  • luma: Model.render() is deprecated. Use Model.setUniforms() and Model.draw()

Line Layer Example

  • deck: LineLayer: getStrokeWidth is deprecated and will be removed in a later version. Use getWidth instead

Hexagon Layer Example

Icon Layer Example

GeoJsonLayer (Paths) Example

  • Not rendering
  • luma: Found instanced attributes on non-instanced model transform-model
  • Error: WebGL warning: drawArrays: One active vertex attrib (if any are active) must have a divisor of 0.

ScreenGridLayer Example

  • Error: WebGL warning: : Exceeded 16 live WebGL contexts for this principal, losing the least recently used one.
  • Error: WebGL warning: drawArraysInstanced: Drawing to a destination rect smaller than the viewport rect. (This warning will only be given once)
  • luma: Buffer.size is deprecated and will be removed in a later version. Use Buffer.accessor.size instead
  • luma: Buffer.bytes is deprecated and will be removed in a later version. Use Buffer.byteLength instead
  • luma: Buffer.instanced is deprecated and will be removed in a later version. Use Buffer.accessor.divisor instead

TileLayer Example

  • tile loading takes 1-5 seconds in my testing - will fix in a later release

Brushing Layer Example

  • luma: project_scale has been removed. Use project_size instead
  • luma: project_to_clipspace has been removed. Use project_common_position_to_clipspace instead

ArcLayer docs page

  • deck: ArcLayer: getStrokeWidth is deprecated and will be removed in a later version. Use getWidth instead

BitmapLayer docs page

  • Missing example

H3HexagonLayer and H3ClusterLayer docs page

  • Incorrectly shows PolygonLayer example in docs page

TileLayer docs page

@1chandu
Copy link
Contributor

1chandu commented Apr 8, 2019

The problem is that we have several versions of isWebGL2. The broken one is https://github.com/uber/luma.gl/blob/master/modules/webgl-state-tracker/src/utils/utils.js#L10-L13

It breaks after the gl constant replacement. I'll remove that function use the one in webgl/webgl-utils everywhere: https://github.com/uber/luma.gl/blob/master/modules/webgl/src/webgl-utils/webgl-checks.js#L12-L19

@tarek related issue: visgl/luma.gl#797

@1chandu
Copy link
Contributor

1chandu commented Apr 8, 2019 •
edited
Loading

Testing on Chrome:

  • Examples:

  • Hexagon layer : crashes while picking

    bundle.js:40 TypeError: Cannot read property '1' of undefined
    at An._renderTooltip (bundle.js:61)
    at An.render (bundle.js:61)
  • Tile layer : white screen while zooming in for more than 2/3 seconds
    could be related to tile loading, should we just display old tiles while new ones being loaded?
    Also has following console errors :
Access to image at 'https://c.tile.openstreetmap.org//1/-1/1.png' from origin 'https://jianhuang01.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
c.tile.openstreetmap.org//1/-1/1.png:1 GET https://c.tile.openstreetmap.org//1/-1/1.png net::ERR_FAILED
Image (async)
/deck.gl/#/examples/core-layers/tile-layer:1 Access to image at 'https://c.tile.openstreetmap.org//1/-1/0.png' from origin 'https://jianhuang01.github.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
c.tile.openstreetmap.org//1/-1/0.png:1 GET https://c.tile.openstreetmap.org//1/-1/0.png net::ERR_FAILED
bundle.js:1 Uncaught (in promise) Error: Could not load image https://c.tile.openstreetmap.org//1/-1/1.png: [object Event]
    at Image.o.onerror (bundle.js:1)
o.onerror @ bundle.js:1
bundle.js:1 Uncaught (in promise) Error: Could not load image https://c.tile.openstreetmap.org//1/-1/0.png: [object Event]
    at Image.o.onerror (bundle.js:1)
  • Brushing layer : errors
`project_scale` has been removed. Use `project_size` instead
`project_to_clipspace` has been removed. Use `project_common_position_to_clipspace` instead

  • Documentation

  • Too many links for older docs, should we only include one link to older revision, i.e. remove 5.3, 5.2, 5.1but just keep5.0`.

  • Upgrade Guide: Confusing heading/subheadings. (Module : Breaking Changes Deprecations), match the formatting of 6.4 to 7.0 section to 6.3 to 6.4 section.

@1chandu 1chandu mentioned this issue Apr 9, 2019
Merged
@tgorkin tgorkin added this to the 7.0.0 milestone Apr 10, 2019
This was referenced Apr 11, 2019
Merged
Merged
@tgorkin tgorkin mentioned this issue Apr 15, 2019
Merged
@jianhuang01 jianhuang01 mentioned this issue Apr 15, 2019
Merged
@jianhuang01
Copy link
Contributor

Icon Layer example not working (Firefox only) and TileLayer docs page example crashes (Firefox only) are caused by @babel/polyfill, once remove it the two examples work well, but without the @babel/polyfill, IE won't work.

@jianhuang01 jianhuang01 mentioned this issue Apr 16, 2019
Merged
@jianhuang01
Copy link
Contributor

jianhuang01 commented Apr 17, 2019 •
edited
Loading

Test on Safari

  • screen grid layer example crashes
  • deckgl-api-reference/layers/grid-layer link is wrong
  • Developer-Guide/subclassed-layers has wrong link to writing shaders
  • ScreenGridLayer doc uses deprecated APIs as example code, this page also emits warnings about deprecated APIs
  • SolidPolygonLayer link is wrong in GeoJsonLayer doc
  • TileLayer example emits deprecated luma.gl API warning
  • warning on homepage: Legacy 64-bit mode only works with coordinateSystem set to
    COORDINATE_SYSTEM.LNGLAT_DEPRECATED. Rendering in 32-bit mode instead
  • PointCloudLayer doc has deprecated API warning.

This was referenced Apr 17, 2019
Merged
Merged
@tgorkin tgorkin closed this as completed Apr 17, 2019
@tgorkin tgorkin reopened this Apr 17, 2019
@tsherif
Copy link
Contributor

tsherif commented Apr 17, 2019 •
edited by jianhuang01
Loading

  • Deck.gl site doesn't work at all in Edge or IE. Just a blank white page.
    In Edge: "Expected identifier, string or number"
    In IE: "Invalid character"

@jianhuang01 jianhuang01 mentioned this issue Apr 17, 2019
Merged
@ibgreen ibgreen mentioned this issue Apr 18, 2019
Merged
@tgorkin tgorkin mentioned this issue Apr 18, 2019
Merged
@jianhuang01 jianhuang01 mentioned this issue Apr 18, 2019
Merged
@tgorkin tgorkin closed this as completed May 20, 2019
@bodom0015 bodom0015 mentioned this issue Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgorkin tgorkin

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
5 participants
@tsherif @tgorkin @Pessimistress @1chandu @jianhuang01