HeatmapLayer/GPUAggregator: fix WebGL feature checking #3483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!isWebGL2(gl)) { | ||
| log.error(`HeatmapLayer ${this.id} is not supported on this browser, requires WebGL2`)(); | ||
| if (!hasFeatures(gl, REQUIRED_FEATURES)) { | ||
| const info = REQUIRED_FEATURES.reduce( |
There was a problem hiding this comment.
Call GPUAggregator.isSupported?
There was a problem hiding this comment.
Though the checks are same, HeatmapLayer doesn't use GPUGridAggregator, in future it is possible these feature list will change.
| if (!hasFeatures(gl, REQUIRED_FEATURES)) { | ||
| const info = REQUIRED_FEATURES.reduce( | ||
| (acc, feature) => | ||
| `${acc} ${feature}: ${hasFeatures(gl, feature) ? 'SUPPORTED' : 'NOT SUPPORTED'} `, |
There was a problem hiding this comment.
- this is technically debug info. I suggest moving this into
hasFeatureand uselog.log(NON_ZERO_PRIORITY, ...) mapand thenjoinwill be more readable.
1chandu
force-pushed
the
HeatmapLayerCrash
branch
from
31d7180
to
9f42694
Compare
|
luma.gl now logs, when feature is checked and not supported. Updated |
Pessimistress
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3480
Requires: visgl/luma.gl#1210
Background
Fix
featurechecking in Heatmap Layer and GPUGridAggregator.Change List