Aggregation Module: CPU Aggregation consolidation and integration with AttributeManager #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1chandu
force-pushed
the
CPUAggregationRefactor
branch
from
c997007
to
5129e15
Compare
1chandu
changed the title
| @@ -218,6 +189,21 @@ export default class ContourLayer extends GridAggregationLayer { | |||
| return strokeWidth; | |||
| } | |||
|
|
|||
| _updateSubLayerTriggers(oldProps, props) { | |||
| if (oldProps && oldProps.contours && props && props.contours) { | |||
There was a problem hiding this comment.
Perf: first check if they are the same object
modules/aggregation-layers/src/cpu-grid-layer/grid-aggregator.js
Outdated
Show resolved
Hide resolved
|
|
||
| _updateAggregationFlags(opts) { | ||
| // Sublayers should implement this method. | ||
| log.assert(false)(); |
There was a problem hiding this comment.
assert doesn't return a function.
heshan0131
reviewed
Nov 26, 2019
heshan0131
reviewed
Nov 26, 2019
1chandu
force-pushed
the
CPUAggregationRefactor
branch
from
c9f19d4
to
1434e14
Compare
This was referenced Dec 3, 2019
Merged
|
Resolved all comments in #3954, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3583
Background
positiondata from AttributeManager.AggregationLayerGPUGridLayerno longer supports CPU Aggregation, one should useCPUGridLayer.Change List