[PART-3] CPUAggregation Refactor : Remove CPU Aggregation from GPUGridAggregator #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1chandu
force-pushed
the
CPUAggregationRefactor2
branch
from
12086b1
to
4da7135
Compare
1chandu
force-pushed
the
CPUAggregationRefactor3
branch
from
48ef7a4
to
7b72da4
Compare
1chandu
force-pushed
the
CPUAggregationRefactor2
branch
from
78bd3d8
to
9aa43ad
Compare
1chandu
force-pushed
the
CPUAggregationRefactor3
branch
from
7b72da4
to
236e258
Compare
modules/aggregation-layers/src/utils/gpu-grid-aggregation/gpu-grid-aggregator.js
Outdated
Show resolved
Hide resolved
1chandu
force-pushed
the
CPUAggregationRefactor2
branch
from
9aa43ad
to
27f6cec
Compare
1chandu
force-pushed
the
CPUAggregationRefactor3
branch
from
236e258
to
780d45a
Compare
Pessimistress
approved these changes
Dec 6, 2019
…dAggregationLayer (#3954) * Consolidate CPU Aggregation * ContourLayer: only perform shallow compare for contours prop, individual triggers not needed anymore * Conver matrix multiply to translation/scaling * Remove fp64 flag and dependency on project64 module * Unify screenspace projections, remove usage of gridTransformMatrix * Use 3D position for CPU and GPU aggregation * GPUAggregation: use 64 bit position attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3583
NOTE: Splitting #3912 to multiple stacked PRs, will close #3912 (keeping it open for existing discussions to be resolved).
Background
AggregationLayer, will be added in next PR).Change List