Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use offsetX & offsetY instead of x & y to get relative positions #445

Merged
merged 2 commits into from
Mar 22, 2017
Merged

use offsetX & offsetY instead of x & y to get relative positions #445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
065aeab
use offsetX & offsetY instead of x & y to get relative positions
Mar 22, 2017
2a895d3
drop event if sanity check fails
Mar 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/react/deckgl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,11 @@ export default class DeckGL extends React.Component {

// Route events to layers
_onClick(event) {
const {x, y} = event;
// use offsetX|Y for relative position to the container, drop event if falsy
if (!event || !event.event || !Number.isFinite(event.event.offsetX)) {
return;
}
const {event: {offsetX: x, offsetY: y}} = event;
const selectedInfos = this.layerManager.pickLayer({x, y, mode: 'click'});
if (selectedInfos.length) {
const firstInfo = selectedInfos.find(info => info.index >= 0);
Expand All @@ -130,7 +134,10 @@ export default class DeckGL extends React.Component {

// Route events to layers
_onMouseMove(event) {
const {x, y} = event;
if (!event || !event.event || !Number.isFinite(event.event.offsetX)) {
return;
}
const {event: {offsetX: x, offsetY: y}} = event;
const selectedInfos = this.layerManager.pickLayer({x, y, mode: 'hover'});
if (selectedInfos.length) {
const firstInfo = selectedInfos.find(info => info.index >= 0);
Expand Down