Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GreatCircleLayer rendering bug #4677

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Fix GreatCircleLayer rendering bug #4677

merged 1 commit into from
Jun 15, 2020

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Jun 14, 2020 •
edited
Loading

For #4621

Before
Screen Shot 2020-06-13 at 5 31 45 PM

After
Screen Shot 2020-06-13 at 5 31 54 PM

The fix

image

Change List

  • Handle the case where the great circle path crosses the 180th meridian
  • Better test data in layer-browser
  • Render test

@coveralls
Copy link

coveralls commented Jun 14, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-3.0%) to 80.056% when pulling 16b7fce on x/great-circle-fix into 2d66b48 on master.

@Pessimistress Pessimistress merged commit cacb22d into master Jun 15, 2020
@Pessimistress Pessimistress deleted the x/great-circle-fix branch June 15, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pessimistress @coveralls @xintongxia @ibgreen