Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onHover/tooltip flickering #4685

Merged
merged 2 commits into from
Jun 18, 2020
Merged

Fix onHover/tooltip flickering #4685

merged 2 commits into from
Jun 18, 2020

Conversation

Pessimistress
Copy link
Collaborator

onHover is called with an empty pickingInfo if the cursor moves from one pickable layer to another.

This only happens to hover events, as we produce a "mouse out" event before the "mouse over":

if (lastPickedLayer) {
// Let leave event fire before enter event
affectedLayers.unshift(lastPickedLayer);
}

Change List

  • Call onHover/getTooltip with a picked info if any

@coveralls
Copy link

coveralls commented Jun 17, 2020

Coverage Status

Coverage decreased (-2.9%) to 80.137% when pulling b4c79b7 on x/picking-fix into 8af69dc on master.

@Pessimistress Pessimistress merged commit 4e69833 into master Jun 18, 2020
@Pessimistress Pessimistress deleted the x/picking-fix branch June 18, 2020 22:58
Pessimistress added a commit that referenced this pull request Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants