Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer able to detect when hovering ends #4695

Closed
mitchwilliamson opened this issue Jun 19, 2020 · 2 comments
Closed

No longer able to detect when hovering ends #4695

mitchwilliamson opened this issue Jun 19, 2020 · 2 comments
Assignees
Labels

Comments

@mitchwilliamson
Copy link

Description

After updating to 8.1.10 our tooltip logic appears to no longer function. We use a similar method to the tooltip example from the docs. Previously we could detect the mouse leaving a point by checking if the picking info .object property is defined. After updating it appears that this is no longer the case as onHover isn't called with an empty object.

I've used the example code from the link above and it also appears to no longer function correctly.

Downgrading to 8.1.9 fixes the issue, so it may be related to #4685?

Repro Steps

    const layer = new ScatterplotLayer({
      data: [{ position: [-122.45, 37.78], message: 'Hover over me' }],
      getPosition: d => d.position,
      getRadius: 1000,
      getFillColor: [255, 255, 0],
      pickable: true,
      onHover: info => console.log(info.object ? 'hovering' : 'left')
    });
  1. Hover over the circle.
  2. Leave the circle.
  3. left is never logged.

My output on v8.1.9

hovering
left

My output on v8.1.10

hovering

Environment (please complete the following information):

  • deck.gl 8.1.10
  • Browser Version: Electron 8.3.2 (Chrome 80)
  • OS: Windows 10
@Pessimistress
Copy link
Collaborator

Try 8.1.11

@mitchwilliamson
Copy link
Author

It works fine again in 8.1.11, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants