Added a getCanvas helper function on deck #7919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change typescript annotation to make the Deck instance canvas readonly instead of protected. Right now there isn't a way to access the canvas instance [as seems to be suggested](visgl#4436 (comment)), as Typescript forbids it. It's possible to cast the deck instance as `any` before getting the canvas prop but this way provides a formalized accessor.
felixpalmer
requested changes
Jun 1, 2023
chrisgervang
changed the title
|
Add the new method to the documentation page? |
Pessimistress
approved these changes
Sep 15, 2023
felixpalmer
approved these changes
Sep 18, 2023
|
Would love to see this merged! :) |
Pessimistress
added a commit
that referenced
this pull request
Oct 4, 2023
Right now there isn't a way to access the canvas instance [as seems to be suggested](#4436 (comment)), as Typescript forbids it. * add a getCanvas helper * documentation and MapboxOverlay.getCanvas --------- Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com>
felixpalmer
pushed a commit
that referenced
this pull request
Oct 11, 2023
Right now there isn't a way to access the canvas instance [as seems to be suggested](#4436 (comment)), as Typescript forbids it. * add a getCanvas helper * documentation and MapboxOverlay.getCanvas --------- Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7918
Background
Change typescript annotation to make the Deck instance canvas readonly instead of protected. Right now there isn't a way to access the canvas instance as seems to be suggested, as Typescript forbids it. It's possible to cast the deck instance as
anybefore getting the canvas prop but this way provides a formalized accessor.Change List
getCanvashelper function on deck