Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getCanvas() in GoogleMapsOverlay #8272

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

felixpalmer
Copy link
Collaborator

Followup to #7919

Change List

  • Also use getCanvas() in GoogleMapsOverlay
  • Defensive checks for when canvas isn't available

Copy link
Collaborator

@akre54 akre54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@felixpalmer felixpalmer merged commit aaac657 into master Nov 9, 2023
2 checks passed
@felixpalmer felixpalmer deleted the felix/google-get-canvas branch November 9, 2023 18:26
@CptCompiler
Copy link

@chrisgervang thank you for all your great work.
I just had a little issue with my packages.
I'm not an expert, but shouldn't the peerDependency in @deck.gl/google-maps be updated to this new version? (8.9.33)
My deck.gl core package was still version 8.9.25 and I got the error: this._deck.getCanvas is not a function

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants