Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable render tests #8138

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Enable render tests #8138

merged 3 commits into from
Sep 26, 2023

Conversation

Pessimistress
Copy link
Collaborator

For #7457

Re-enable render tests for core layers and simple composite layers. Still disabled: binary attribute test cases, GPU aggregation layers, GPU-based effects and extensions

Change List

  • Upgrade to luma.gl 9.0.0-alpha.36
  • Update WebGL functions to new API name
  • Enable some render tests
  • Bug fix in constant attribute + shader attribute handling
  • Bug fix in PathStyleExtension
  • Bug fix in TextBackgroundLayer

ibgreen
ibgreen approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress. Let's land and make a plan for which of the commented tests we want to unbreak first.

@ibgreen ibgreen merged commit 4154c68 into master Sep 26, 2023
2 checks passed
@ibgreen ibgreen deleted the x/render-test branch September 26, 2023 10:40
@felixpalmer felixpalmer mentioned this pull request Oct 2, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @ibgreen