Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix widget module publishing #8178

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[chore] Fix widget module publishing #8178

merged 2 commits into from
Oct 13, 2023

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Oct 6, 2023 •
edited
Loading

For #7946 #8182

Change List

chrisgervang
chrisgervang approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought babel's transform-jsx plugin was sufficient for widgets. Was there some part of the publishing script that needed the full react preset?

@Pessimistress Pessimistress changed the title Bump ocular-dev-tools [chore] Fix widget module publishing Oct 13, 2023
@Pessimistress Pessimistress merged commit 158af26 into master Oct 13, 2023
2 checks passed
@Pessimistress Pessimistress deleted the x/bump-ocular branch October 13, 2023 04:03
Pessimistress added a commit that referenced this pull request Oct 13, 2023
@Pessimistress
[chore] Fix widget module publishing (#8178)
c527e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang chrisgervang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pessimistress @chrisgervang