fix(widgets): use assigned viewport to change viewState #8903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Gervang <chris@gervang.com>
felixpalmer
approved these changes
May 20, 2024
| @@ -117,7 +117,7 @@ export class CompassWidget implements Widget<CompassWidgetProps> { | |||
| } | |||
|
|
|||
| handleCompassReset() { | |||
| const viewId = this.viewId || 'default-view'; | |||
| const viewId = this.viewId || this.viewport?.id || 'default-view'; | |||
There was a problem hiding this comment.
Seems a bit clunky that this needs to be duplicated across widgets, it would be nice if we could push this complexity into the WidgetManager somehow. Also, can the this.viewport?.id ever be different from the viewId? If not, we could just do:
const viewId = this.viewport!.id || 'default-view';There was a problem hiding this comment.
Widgets implement how they handle this themselves since not every widget is tied to a view (FullscreenWidget has no view code in it).
I think viewId and viewport can differ in multi-view. I have some questions about multi-view widgets to look into next, so I'll follow up on this soon. The intended design is:
- If a
viewIdprop is defined by a user, the widget is placed in that view (i.e. a mini-map) and changes that view. - Otherwise, the widget should be placed in the default top-left view container and change all views.
Pessimistress
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8902
Change List