fix(carto): Support picking with MVT tile-relative coordinates #8926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
zbigg
approved these changes
May 29, 2024
|
Let's hold this PR until next week, to get a review from @felixpalmer as well. |
felixpalmer
approved these changes
May 30, 2024
| @@ -151,6 +151,12 @@ export default class VectorTileLayer< | |||
| getPickingInfo(params) { | |||
| const info = super.getPickingInfo(params); | |||
|
|
|||
| // MVT tiles use tile-relative coordinates, handled by MVTLayer#getPickingInfo. | |||
| if (this.state.mvt) { | |||
There was a problem hiding this comment.
While this fixes the issue, I notice that it code path below will mean that binaryToGeojson is invoked twice. We could do better, either by invoking super.super.getPickingInfo here (https://stackoverflow.com/a/49056678) or modifying the MVTLayer to move isWGS84 to state and overriding it in VectorTileLayer. @donmccurdy could you give this a try in a follow-up PR?
There was a problem hiding this comment.
Good call, thanks! Opened a followup PR in #8932.
donmccurdy
force-pushed
the
donmccurdy/fix-carto-vectortilelayer-getpickinginfo
branch
from
49a78e7
to
b76cc26
Compare
donmccurdy
deleted the
donmccurdy/fix-carto-vectortilelayer-getpickinginfo
branch
felixpalmer
pushed a commit
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
test/modules/carto/layers/vector-tile-layer.spec.tstest/modules/carto/layers/carto-tile-layer.spec.tsRelated: