Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(geo-layers): Allow layers extending MVTLayer to override isWGS84 #8932

Merged
merged 3 commits into from
Jun 4, 2024
Merged

feat(geo-layers): Allow layers extending MVTLayer to override isWGS84 #8932

merged 3 commits into from
Jun 4, 2024

Conversation

donmccurdy
Copy link
Collaborator

Changes:

  • feat(geo-layers): Expose protected method, _isWGS84
  • chore(carto): Use _isWGS84 to avoid building picking info twice

Related:

@donmccurdy donmccurdy mentioned this pull request Jun 3, 2024
Merged
@coveralls
Copy link

coveralls commented Jun 3, 2024 •
edited
Loading

Coverage Status

coverage: 89.901% (-0.002%) from 89.903%
when pulling 27d821b on donmccurdy/fix-carto-vectortilelayer-getpickinginfo-pt2
into 12e837f on master.

@donmccurdy donmccurdy merged commit cd29436 into master Jun 4, 2024
4 checks passed
@donmccurdy donmccurdy deleted the donmccurdy/fix-carto-vectortilelayer-getpickinginfo-pt2 branch June 4, 2024 16:46
felixpalmer pushed a commit that referenced this pull request Jun 12, 2024
@donmccurdy @felixpalmer
feat(geo-layers): Allow layers extending MVTLayer to override isWGS84 (…
eb0a186 
…#8932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donmccurdy @coveralls @felixpalmer