Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some styling and layout on gatsby website example info panels. #1248

Merged
merged 2 commits into from
Sep 18, 2019

Conversation

tgorkin
Copy link
Contributor

@tgorkin tgorkin commented Sep 18, 2019

For #756

Fixes headers and View Code links on example info panels.

Screen Shot 2019-09-17 at 5 06 24 PM

@@ -136,7 +138,7 @@ export default class AnimationLoopExamplePage extends Component {
}

render() {
const {name, panel = true, stats, sourceLink} = this.props;
const { exampleConfig: { title , path } = {}, panel = true, stats } = this.props;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use spaces inside curly braces.

In VS Code,

install prettier plugin and update

go to preferences (workspace or global), and set

"typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
"javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,

@tgorkin tgorkin merged commit 1b7cb7b into master Sep 18, 2019
@coveralls
Copy link

coveralls commented Sep 18, 2019

Coverage Status

Coverage increased (+4.1%) to 67.21% when pulling 3a23515 on tgorkin/website-info-panels into f58d82d on master.

@1chandu 1chandu mentioned this pull request Sep 20, 2019
59 tasks
@Pessimistress Pessimistress deleted the tgorkin/website-info-panels branch November 16, 2020 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants