Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to add MetaEvent 8 in events.py #44

Closed
hskim08 opened this issue Oct 8, 2014 · 3 comments
Closed

Need to add MetaEvent 8 in events.py #44

hskim08 opened this issue Oct 8, 2014 · 3 comments

Comments

@hskim08
Copy link
Contributor

hskim08 commented Oct 8, 2014

In events.py, it is missing MetaEvent 0x08.
According to MIDI recommended practice 19, it is recommended to be used as "Program Name".
(http://www.midi.org/techspecs/rp19.php)
@vishnubob
Copy link
Owner

Would you be willing to submit a pull request with this enhancement?

@hskim08
Copy link
Contributor Author

hskim08 commented Oct 9, 2014

Sure. (This is the first time for me to submit a pull request.)

@vishnubob
Copy link
Owner

It's a great skill to learn, and I'm happy to receive your contributions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vishnubob @hskim08