Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - Option to reduce/remove margins #39

Closed
Pastitas opened this issue Feb 7, 2024 · 3 comments
Closed

Feature request - Option to reduce/remove margins #39

Pastitas opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Pastitas
Copy link

Pastitas commented Feb 7, 2024

In the readme there's a section that lists not taking up the full width, but It's unclear to me if this is intended or a bug.
Is there any knowledge so far about those margins if it's a bug, and if it's a feature could it be tweaked?

@Pastitas Pastitas changed the title Option to reduce/remove margins Feature request - Option to reduce/remove margins Feb 7, 2024
@Vishram1123 Vishram1123 added the enhancement New feature or request label Feb 10, 2024
@Vishram1123
Copy link
Owner

There was a pull request made a while back to change the spacing preferences. It is intended to have a border when you set the width to 100%; what I was talking about when it said that it wasn't taking up the full width was that you could snap to the left and right separately when setting the width to 100% (as in, it wasn't properly setting the width to the maximum size minus the spacing). I will add an option to change the snap spacing, but the bug I am referring to is unrelated to the spacing on the left and right; that is fully intentional

@Vishram1123 Vishram1123 self-assigned this Feb 10, 2024
@Pastitas
Copy link
Author

Okay then I kinda got it as it was. Thanks for considering this!

@Vishram1123
Copy link
Owner

Implemented in ad33bdd. The issue with the keyboard not taking up the full width still exists, though I believe this is a rounding issue, as st.button doesn't like floating point values for width and height

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants