Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about box-sizing border-box? #233

Closed
danwdart opened this issue Nov 30, 2013 · 5 comments
Closed

How about box-sizing border-box? #233

danwdart opened this issue Nov 30, 2013 · 5 comments

Comments

@danwdart
Copy link

It's in all my resets I've used recently, so might be a great idea to include by default (or as option)?

@notslang
Copy link
Collaborator

Err... that seems like a pretty extreme change to set everything to box-sizing: border-box. What resets are you using?

@danwdart
Copy link
Author

My usual resets are:

  • {
    padding:0;
    margin: 0;
    box-sizing: border-box;
    -webkit-box-sizing: border-box;
    -moz-box-sizingL border-box;
    }

html, body {
height:100%;
padding: 0 !important;
margin: 0 !important;
}

@buschtoens
Copy link
Contributor

I've been working with bootstrap for some time now, and I gotta say, that the border-box has extreme advantages over the default one.

However, this should be still up to the user. Everyone learns CSS the default way. Without very visibly denoting it somewhere, this change will introduce a lot of confusion and frustration.

Sent from an iPhone, so please excuse shitty spelling.

On Sat, Nov 30, 2013 at 4:02 PM, Dan Dart notifications@github.com
wrote:

My usual resets are:

  • {
    padding:0;
    margin: 0;
    box-sizing: border-box;
    -webkit-box-sizing: border-box;
    -moz-box-sizingL border-box;
    }
    html, body {
    height:100%;
    padding: 0 !important;
    margin: 0 !important;
    }

    Reply to this email directly or view it on GitHub:
    How about box-sizing border-box? #233 (comment)

@notslang
Copy link
Collaborator

notslang commented Dec 8, 2013

Well, imma close this for now. Reopen if you wanna continue the discussion, but as @silvinci said, it could introduce a lot of confusion and frustration. It could be a setting, but it would do so little it's hardly worth including. It would just be:

*
    box-sizing: border-box

@notslang notslang closed this as completed Dec 8, 2013
@danwdart
Copy link
Author

danwdart commented Dec 8, 2013

Fair enough. That'll be in mine anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants