Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support hash instead of path directly. #112

Closed
wenerme opened this issue Jul 7, 2014 · 8 comments
Closed

support hash instead of path directly. #112

wenerme opened this issue Jul 7, 2014 · 8 comments

Comments

@wenerme
Copy link

wenerme commented Jul 7, 2014

Like angularjs, route with/without hash is ok. dose pagejs support route with hash ?

Like

route / to #/

route /about to #/about

In pagejs, even page('#/about') will not work.

@A
Copy link
Member

A commented Jul 7, 2014

Interesting idea. I think that it will be useful and not difficult to do

@A
Copy link
Member

A commented Jul 7, 2014

Can you pull a request?

@wenerme
Copy link
Author

wenerme commented Jul 7, 2014

I got a problem about this, want to implement it. I think this is very important for non-html5 browsers.

@A
Copy link
Member

A commented Jul 7, 2014

yep, I plan to add support for legacy-browsers or phonegap by hashbang option: #86

@A
Copy link
Member

A commented Jul 7, 2014

I would like to not get a conflict between hashbang and support routes, beginning with #. But right now I have no Idea for this. mb you have one?

@wenerme
Copy link
Author

wenerme commented Jul 7, 2014

I just stop my project there, wait for the feature support
On Jul 7, 2014 9:04 PM, "Shuvalov Anton" notifications@github.com wrote:

I would like to not get a conflict between hashbang and support routes,
beginning with #. But right now I have no Idea for this. mb you have one?


Reply to this email directly or view it on GitHub
#112 (comment).

@conraddecker
Copy link
Contributor

Here's an updated pull request if it helps in any way: #128. It's based off of @quangv's original work in Pull Request #86 but accounts for the most recent work on the library.

Hopefully that'll help and can get merged in.

@A
Copy link
Member

A commented Sep 28, 2014

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants