pass the original error message to the catched error

[timaschew]

superagent is catching all errors: https://github.com/visionmedia/superagent/blob/f106c7226758a22f633d0cf1607b5bb6a3ce264e/lib/client.js#L458

so if you make a request and get a runtime error in the response callback it's totally annoying, because you only get a Parser is unable to parse the response and you need to debug it to get the origin error message, which has nothing to do with parsing the response.

[timaschew]

@gjohnson
why the try block wraps the callback as well?
Isn't it enough to catch just the var res = new Response(self); ?

https://github.com/visionmedia/superagent/blob/f106c7226758a22f633d0cf1607b5bb6a3ce264e/lib/client.js#L454

[timaschew]

maybe something like that:

  this.on('end', function(){
    var res;
    try {
     res = new Response(self);
    } catch(e) {
      var err = new Error('Parser is unable to parse the response');
      err.parse = true;
      err.original = e;
      self.callback(err);
    }
    if ('HEAD' == method) res.text = null;
    try {
      self.callback(null, res);
    } catch(e) {
      self.callback(e);
    }
  });
}

[joanniclaborde]

+1

[dcousens]

+1

[constantx]

👍

[defunctzombie]

This has been fixed in master. The callback is not in the try/catch anymore.

[dcousens]

Any word on a publish?
On 22 Feb 2015 6:01 pm, "Roman Shtylman" notifications@github.com wrote:

Closed #450 #450.

—
Reply to this email directly or view it on GitHub
#450 (comment).

[defunctzombie]

Yea, I am trying to blow through the issue backlog today and tomorrow and want to try to get an RC out tomorrow but can't promise anything.

If you want to use master today you can certainly just reference git commits directly.