Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use with Angular 16 #457

Closed
4 tasks done
moodyVlad opened this issue May 10, 2023 · 5 comments
Closed
4 tasks done

Cannot use with Angular 16 #457

moodyVlad opened this issue May 10, 2023 · 5 comments

Comments

@moodyVlad
Copy link

moodyVlad commented May 10, 2023

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed
  • I'm reporting the issue to the correct repository

Current Behavior

Getting the following error when importing VisModule inside another module or standalone component after update to Angular 16.
Component imports must be standalone components, directives, pipes, or must be NgModules.

Expected Behavior

VisModule can correctly be imported when using angular 16.

Failure Information

Component imports must be standalone components, directives, pipes, or must be NgModules.

Steps to Reproduce

  1. Create an Angular 16 application
  2. Install ngx-vis
  3. import VisModule inside any angular module or standalone component.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Angular 16.0.0:
  • NodeJS version 16+:
  • Operating System: W11:
@hypery2k
Copy link
Collaborator

Give the new version a try: npm i ngx-vis@next
I don't have much more capacity for the project. If any volunteer wants to take-over/step in, feel free to contact me

@Airex
Copy link

Airex commented May 17, 2023

@hypery2k
i was able to move my proj from angular 13 to 16,

"@angular/animations": "^16.0.2",
"@angular/cdk": "^16.0.1",
"@angular/common": "^16.0.2",
"@angular/compiler": "^16.0.2",
"@angular/core": "^16.0.2",
"@angular/forms": "^16.0.2",
"@angular/platform-browser": "^16.0.2",
"@angular/platform-browser-dynamic": "^16.0.2",
"@angular/router": "^16.0.2",

"ng-zorro-antd": "^15.1.0",

"ngx-vis": "3.1.2-build1683917720",

"vis-data": "^7.1.6",
"vis-util": "^5.0.3",

@Maximaximum
Copy link

ngx-vis@next seems to work.

@hypery2k would you please consider releasing current version as a stable release?

@hypery2k
Copy link
Collaborator

great to here. Will make a v4 release

Thanks for the feedback

@hypery2k
Copy link
Collaborator

v4 is out out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants