fix(a11y): solve some issues #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tabindex on the network is 0 now. - All pages now declare their language. - Manipulation buttons are buttons now. - Manipulation buttons are tabbable now. - Manipulation buttons can be triggered by the keyboard (enter, space). - Manipulation close button has aria label.
yotamberk
approved these changes
Dec 18, 2020
|
🎉 This PR is included in version 8.5.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the stuff was just about ignoring accessibility (I'm sure there still is a lot to improve.) but one thing that stands out is the tabindex attribute on the network element (as reported by #1238). I wonder why it was set to 900. No matter how I think about it, 900 just seems nonsensical to me (also, pretty arbitrary value). The only thing it achieves is bizarre tabbing behavior (It would be focused as the first thing in the page no matter where it's placed, unless something has positive tabindex of 899 or less.).
This PR will change how tabbing works in pages using Vis Network. However I can't imagine why would anyone want it the old way. From my perspective, Vis Network used to mess up tabbing order and now it doesn't. We may discuss this further though, as there may be situations where this could be considered a breaking change, I just don't see any.
Closes #1238.