Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<RV32I> Assembler directives may be faulty. #257

Closed
akashkollipara opened this issue Dec 8, 2023 · 1 comment · Fixed by #272
Closed

<RV32I> Assembler directives may be faulty. #257

akashkollipara opened this issue Dec 8, 2023 · 1 comment · Fixed by #272
Assignees
@Kashish0212
Labels
bug-critical System failure can be predicted cyancore framework Cyancore framework feature request terravisor Terravisor related issue

Comments

@akashkollipara
Copy link
Member

Describe the bug
In rv32i entry.S .option norvc can cause trouble.

Expected behavior
Sequence of push and norvc needs to be changed.
@akashkollipara akashkollipara added terravisor Terravisor related issue cyancore framework Cyancore framework feature request bug-critical System failure can be predicted labels Dec 8, 2023
@akashkollipara akashkollipara added this to the Boron milestone Dec 8, 2023
Kashish0212 added a commit that referenced this issue Dec 8, 2023
@Kashish0212
<RV32I> Fixed the order of assembler directives <- fixed the placement
d704c00 
of the push arg

Issue: #257
Kashish0212 added a commit that referenced this issue Dec 8, 2023
@Kashish0212
<RV32I> Fixed the order of assembler directives
3706fb8 
Issue: #257
Kashish0212 added a commit that referenced this issue Dec 8, 2023
@Kashish0212
<RV32I> Fixed the order of assembler directives
95233bd 
Issue: #257
@Kashish0212 Kashish0212 mentioned this issue Dec 8, 2023
Merged
@akashkollipara
Copy link
Member Author

akashkollipara commented Dec 8, 2023 •
edited
Loading

[Resolved] Closing this issue. Thanks @Kashish0212

@akashkollipara akashkollipara linked a pull request Jan 3, 2024 that will close this issue
Development #272
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kashish0212 Kashish0212

Labels
bug-critical System failure can be predicted cyancore framework Cyancore framework feature request terravisor Terravisor related issue
Projects
Terravisor
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Development VisorFolks/cyancore
2 participants
@akashkollipara @Kashish0212