Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Robot Libraries window for MacOS #144

Closed
1 task done
lin-ycv opened this issue Mar 4, 2022 · 5 comments
Closed
1 task done

[Bug] Robot Libraries window for MacOS #144

lin-ycv opened this issue Mar 4, 2022 · 5 comments
Labels

Comments

@lin-ycv
Copy link
Contributor

lin-ycv commented Mar 4, 2022

Is there an existing issue for this?

  • I have searched the existing issues

What Robots version are you using?

1.1.8

What Rhino version are you using?

Rhino 7 on MacOS

Current Behavior

Robot Libraries window is not displaying correctly, cannot read names.
image

Expected Behavior

text and icons to be displayed correctly
image

Steps To Reproduce

open Robot Libraries window in MacOS

Anything else?

No response

@lin-ycv lin-ycv added the bug label Mar 4, 2022
@visose
Copy link
Owner

visose commented Mar 4, 2022

Thanks. I'll check why the cells of the grid are so narrow. I think the rest of the text not showing up (in the buttons, title, description) is probably because I have forced a white background and the text color in dark theme is also white. I'll remove any forced styling to avoid this.

Besides this does everything else work? Clicking on the buttons, etc.

@visose
Copy link
Owner

visose commented Mar 6, 2022

image

I think this is fixed now. Had to force the height of the rows, since in mac it doesn't compute the correct height (there's an issue open in the eto repo about this).
I had to also force the background color of the panel to be transparent, if not, it uses a light gray color rather than the dark theme background color.
I also fixed the spinners next to the buttons, they were cropped a bit on mac.

I noticed the toolbar icons look terrible in mac, and not only the Robots ones. Do people use Rhino/Grasshopper with the dark theme?

@visose
Copy link
Owner

visose commented Mar 6, 2022

@lin-ycv could you check if it looks fixed in the latest release, and if so you can close the issue.

@visose
Copy link
Owner

visose commented Mar 6, 2022

I just noticed another issue with the form in Mac, the icon on the list doesn't change when installing/updating/deleting a library. This also seems like an Eto issue in Mac.

I fixed it by updating the list using a different mechanism, it will go into the next update.

@lin-ycv
Copy link
Contributor Author

lin-ycv commented Mar 8, 2022

Sorry for the delayed reply, I don't have ready access to a Mac., but I've just checked and everything seems to be properly formatted now.
The icon issue I don't think is a big deal, will appear as checked after pressing refresh, maybe force a refresh after download?

Most people I know use the dark theme on mac, but I don't think it's that terrible, especially since we usually just use keyword search instead of the toolbar.

Thanks.

@lin-ycv lin-ycv closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants