RELEASES - alpha.7, to master #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the one where we merge master down to develop because Stuart fudged the release order
Sets up a cleaner hirearchy of sass path imports. Also does an npm update.
…t-paths chore: opimise-sas-import-paths
Was using an old version of vf-logo
fix vf-form dependencies
…pendencies fix: vf-global-header-dependencies
Resolve a couple of broken package dependencies.
…rns-to-npm chore: load-latest-patterns-to-npm
Just a cleanup thing I suppose.
…p-files-to-npm Chore: don't send backstop files to npm
…esign-tokens Fix: docs should soft fail when vf-design-tokens aren't present
There should typically never be any components here, but: 1. A developer might drop them in the wrong spot 2. if we're testing the npm directly from github, we need to ignore these
Mostly does two things: - Reduces the amount of spam we're getting when a PR is made and review requested (and I think this phrasing might be more helfpul to external devs) - Tries to fix [ ] checkbox formatting with 2 spaces at end of each line
…sations Feature/gulpfile optimisations
chore: cleanup autocomment
The spacing token names missed an update, that is: `vf-spacing-r` should be `vf-spacing--r` Also adds an issue where nested `.vf-content ul li > ul` didn't have a needed margin at the top.
…umentation Docs/add a bunch of documentation
bug: spacing-token-naming
…ting Bug: Autocomment formatting
Addresses #412 and also address the "spirit" of that ticket, by: - Making the css linting come after the css recompilation - Adds a soft-fail css linting task that won't explode the local deve experience - Fixes `vf-css` to use a better callback approach so that: 1. You get an accurate idea of the css build time 2. A real signal that the vf-css pipe stream has completed 3. No longer get a flash of fractal befor the css build has finished And it should be a bit faster now that fractal won't try to run while the Sass is still building.
This mainly fixes how vf-card was showing without the image when deployed. It relates to #364 on how we need to document this, propbably in the pattern template too. It also sneaks in a fix where the utility mixins were need for the hover effect for the button.
Bug: fix static build path for vf-card
…ilding-linting Enhancement: gulp css building, linting
WIP: the one where we add percy.io, remove BackStopJS and get it as part of the CI build
Addresses #455
A few minor fixes I stumbled on while working on #460: a name for a vf-text variant and the vf-headings demo
* makes use of nunjucks to create variants * makes use of variables and maps and normalises some sizing * small readme update * Elsewhere we've used hyphens, changing for consistency
CHORE: Swap npm for yarn
It's the same as --containers
The below tweak introduced some layout issues as non-layout affecting content out of the content hub (think: blocks) was being escaped from the grid.
```
.embl-content-hub-html {
grid-column: 1 / -1;
}
```
This fixes that by only targeting elements that are direct children of `-grid`.
It also add `.embl-content-hub-html` so we can begin to update classes in the contentHub.
…l-previews Refactor: trim fractal previews
…d-escape bug: vf-conent-hub-html grid-escape
This limits the percy command to only run on commits to develop and compares against master. We might also want to disable the github integration to stop comparissons on PRs, which has chewed through our alotment of screenshots. This also set it only do mobile/desktop for a 33% savings :D But it doesn't really matter until August as we've already gone through our quota!
…ly-on-develop Chore: set percy to run only on develop
As I work through cleaning up docs and making "things more approachable", it became clear that the design tokens can (of course) change in both how they're used and how much technical detail should be shown. With that in mind I've moved the existing `/docs/styles/` to be paired directly with `vf-design-tokens` I think this: 1. Makes it clear that these settings come from `vf-design-tokens` 2. Are where developers might expect the most technical values 3. We can link to from `/docs` 4. Makes it possible to put something more high level in `docs/styles` 5 It also stops the risk of "what happens when there's `docs/styles` but `vf-design-tokens` wasn't installed?
* Update package.json * Update npm versions
|
Thank you for requesting a review for this pull request (PR). If you have not done so already - please fill out the PR description with as much context as possible. Pull request reviewBefore your PR can be merged in, it will need to be reviewed.
|
|
Running with admin privs again for this chore and to save Stu a bit of a hassle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And now we go from develop to master.
Once our visual regression testing is back up, this is when we'd probably want to look for "oh noes! 😭"