-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve skip key #47
Comments
Would |
whereblocks aren't cython based; @FrancescElies his work on iterblocks will work (and make it a lot more readable) but we still have to apply the filter ourselves :/ |
I found this excellent investigation of timings from @FrancescElies: Comment in Chunks Class iterator, PR 153 It looks like he's just using the top level iterblocks though: test_v5 in bench_iter_carray Isn't that defined in python here? iterblocks in toplevel.py |
I'm also happy to put together a PR that reproduces his earlier PR, since that will likely be hard to merge. Would that be helpful? |
@FrancescAlted also did some work to improve performance here (also with tuples vs namedtuples), I will check if we can use that to improve this and save ourselves unneeded chunk decompressions |
It's a slightly ugly method to handle irrelevant results (because of filtering) during a groupby:
The text was updated successfully, but these errors were encountered: